Show root problem list for objects with problem and are part of dependency #1057

raviks789 · 2024-09-17T14:16:03Z

blocked by: #1055
blocked by: Icinga/ipl-web#231

The previous relations didn't work as expected. Now, filtering with `child.host.name` or `parent.service.name` works fine.

…dency

nilmerg

please rebase, #1055 is merged.

nilmerg · 2024-09-24T12:48:49Z

library/Icingadb/Common/StateBadges.php

 *
 * @return ?BaseHtmlElement
 */
- protected function createGroup(string $state)
+ protected function createGroup(string $state, bool $createLink = true)


Drop $createLink and replace it with $this->url !== null

nilmerg · 2024-09-24T12:49:23Z

library/Icingadb/Common/StateBadges.php

- abstract protected function getStateInt(string $state): int;
+ protected function getStateInt(string $state): int
+ {
+ return 0;


Throw InvalidArgumentException instead

nilmerg · 2024-09-24T12:50:34Z

library/Icingadb/Common/StateBadges.php

 *
 * @return ?BaseHtmlElement
 */
- protected function createBadge(string $state)
+ protected function createBadge(string $state, bool $createLink = true)


Drop $createLink and replace it with $this->url !== null

nilmerg · 2024-09-24T12:53:13Z

library/Icingadb/Widget/RedundancyGroupParentStateBadges.php

+
+use Icinga\Module\Icingadb\Common\StateBadges;
+
+class RedundancyGroupParentStateBadges extends StateBadges


Not sure why you named this RedundancyGroupParentStateBadges.

Can't it be just RedundancyGroupStateBadges?

Since I just requested that RedundancyGroupStatistics should be renamed to ObjectsStatistics, these should be ObjectsStateBadges.

nilmerg · 2024-09-24T12:57:53Z

library/Icingadb/Widget/RedundancyGroupParentStateBadges.php

+ return 'redundancy_group_parent';
+ }
+
+ protected function getPrefix(): string
+ {
+ return 'parents';


Groups have members.

Well, objects 😅

nilmerg · 2024-09-24T13:31:09Z

library/Icingadb/Widget/Detail/ObjectDetail.php

+
+ protected function createRootProblems(): ?array
+ {
+ $rootProblems = UnreachableParent::on($this->getDb(), $this->object)


return early if the object is reachable.

nilmerg · 2024-09-24T14:02:24Z

library/Icingadb/Widget/RedundancyGroupStatistics.php

+use ipl\Html\ValidHtml;
+use ipl\Html\HtmlString;
+
+class RedundancyGroupStatistics extends ObjectStatistics


Please rename this to ObjectsStatistics. There is not much which makes this redundancy group specific.

It's just not specific to hosts and services anymore. We will benefit from a generalized implementation somewhere else ;)

nilmerg · 2024-09-24T14:03:36Z

library/Icingadb/Widget/RedundancyGroupStatistics.php

+ ->addSlice($this->summary->parents_ok, ['class' => 'slice-state-ok'])
+ ->addSlice($this->summary->parents_warning_handled, ['class' => 'slice-state-warning-handled'])
+ ->addSlice($this->summary->parents_warning_unhandled, ['class' => 'slice-state-warning'])
+ ->addSlice($this->summary->parents_problem_handled, ['class' => 'slice-state-critical-handled'])
+ ->addSlice($this->summary->parents_problem_unhandled, ['class' => 'slice-state-critical'])
+ ->addSlice($this->summary->parents_unknown_handled, ['class' => 'slice-state-unknown-handled'])
+ ->addSlice($this->summary->parents_unknown_unhandled, ['class' => 'slice-state-unknown'])
+ ->addSlice($this->summary->parents_pending, ['class' => 'slice-state-pending']);


Replace parents_ with objects_

nilmerg · 2024-09-24T14:16:03Z

library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php

+ $filter = Filter::equal('id', $this->item->id);
+ $relations = [
+ 'from',
+ 'from.to.host',
+ 'from.to.host.state',
+ 'from.to.service',
+ 'from.to.service.state'
+ ];
+
+ $summary = RedundancyGroupParentStateSummary::on($this->getDb())
+ ->with($relations)
+ ->filter($filter);
+
+ $members = RedundancyGroup::on($this->getDb())
+ ->columns([
+ 'id' => 'id',
+ 'parent_output' => new Expression(
+ 'CASE WHEN redundancy_group_from_to_host_state.output IS NULL'
+ . ' THEN redundancy_group_from_to_service_state.output'
+ . ' ELSE redundancy_group_from_to_host_state.output END'
+ ),
+ 'parent_long_output' => new Expression(
+ 'CASE WHEN redundancy_group_from_to_host_state.long_output IS NULL'
+ . ' THEN redundancy_group_from_to_service_state.long_output'
+ . ' ELSE redundancy_group_from_to_host_state.long_output END'
+ ),
+ 'parent_checkcommand_name' => new Expression(
+ 'CASE WHEN redundancy_group_from_to_host.checkcommand_name IS NULL'
+ . ' THEN redundancy_group_from_to_service.checkcommand_name'
+ . ' ELSE redundancy_group_from_to_host.checkcommand_name END'
+ ),
+ 'parent_last_state_change' => new Expression(
+ 'CASE WHEN redundancy_group_from_to_host_state.last_state_change IS NULL'
+ . ' THEN redundancy_group_from_to_service_state.last_state_change'
+ . ' ELSE redundancy_group_from_to_host_state.last_state_change END'
+ ),
+ 'parent_severity' => new Expression(
+ 'CASE WHEN redundancy_group_from_to_host_state.severity IS NULL'
+ . ' THEN redundancy_group_from_to_service_state.severity'
+ . ' ELSE redundancy_group_from_to_host_state.severity END'
+ )
+ ])
+ ->with($relations)
+ ->filter($filter)
+ ->orderBy([
+ 'parent_severity',
+ 'parent_last_state_change',
+ ], 'DESC');
+
+ $this->applyRestrictions($members);
+
+ /** @var RedundancyGroup $data */
+ $data = $members->first();


I don't quite like that this is evaluated per group result.

Keep it as it is for now, but update it so that it matches the changes made to the statistics and badges implementation.

I have an alternative implementation in mind, but that's now far to complex for this change and so will be implemented separately. Prior approval of this change, I will request to remove this to not show any badges or output for groups. Until then, it's kept to test the statistics and badges implementation changes.

nilmerg · 2024-09-24T14:17:53Z

library/Icingadb/Widget/ItemList/RedundancyGroupListItem.php

+ $verb = 'has';
+ } else {
+ $verb = 'is';
+ }
+
+ $title->addHtml(Html::sprintf(
+ t('%s %s %s', '<hostname> has/is <state-text>'),
+ $this->createSubject(),
+ $verb,
+ Html::tag('span', ['class' => 'state-text'], $this->state->failed ? 'Failed' : 'OK')


Translatable strings should never be concatenated. Instead, the text to translate should always be complete.

db: Cleanup parent/child relations in matching models

b5a4caa

The previous relations didn't work as expected. Now, filtering with `child.host.name` or `parent.service.name` works fine.

cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 17, 2024

raviks789 force-pushed the root-problem-list branch 10 times, most recently from bc06e1c to 3375e51 Compare September 19, 2024 13:14

raviks789 changed the title ~~WIP~~ Show root problem list for objects that have problem and are part of dependency Sep 19, 2024

raviks789 changed the title ~~Show root problem list for objects that have problem and are part of dependency~~ Show root problem list for objects with problem and are part of dependency Sep 19, 2024

raviks789 force-pushed the root-problem-list branch 5 times, most recently from 4351639 to e77c687 Compare September 23, 2024 07:52

raviks789 marked this pull request as ready for review September 23, 2024 12:19

raviks789 requested a review from nilmerg September 23, 2024 12:19

Show root problem list for objects with problem and are part of depen…

a2fb6b0

…dency

raviks789 force-pushed the root-problem-list branch from e77c687 to a2fb6b0 Compare September 23, 2024 12:29

nilmerg linked an issue Sep 24, 2024 that may be closed by this pull request

Show a list of root problems in the host/service detail if it has a problem and is part of a dependency #1050

Open

nilmerg assigned raviks789 Sep 24, 2024

nilmerg added the enhancement New feature or improvement label Sep 24, 2024

nilmerg requested changes Sep 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show root problem list for objects with problem and are part of dependency #1057

Show root problem list for objects with problem and are part of dependency #1057

raviks789 commented Sep 17, 2024 •

edited

Loading

nilmerg left a comment

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024

nilmerg Sep 24, 2024


		use Icinga\Module\Icingadb\Common\StateBadges;

		class RedundancyGroupParentStateBadges extends StateBadges

Show root problem list for objects with problem and are part of dependency #1057

Are you sure you want to change the base?

Show root problem list for objects with problem and are part of dependency #1057

Conversation

raviks789 commented Sep 17, 2024 • edited Loading

nilmerg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raviks789 commented Sep 17, 2024 •

edited

Loading